B::Queue#pop should use Bunny::MessageProperties

[mmmries]

Right now the Bunny::Queue#pop method returns a triplet of delivery_info, message_properties, payload which looks the same as the values that get yielded from Bunny::Queue#subscribe, but the message_properties value is actually different for these two cases. Subscribe gives back a Bunny::MessageProperties object and pop gives back a Hash.

Example:

require "bunny"

conn = Bunny.new
conn.start

ch   = conn.create_channel
q    = ch.queue("images.resize", :exclusive => false, :auto_delete => true)

delivery_info, message_properties, payload = q.pop
message_properties.class # => Hash

q.subscriber do |delivery_info, message_properties, payload|
  message_properties.class # => Bunny::MessageProperties
end

It would be nice if these two interfaces for getting messages were consistent. If someone wants to be point me in the right direction I'd be happy to take a look and make a pull request.

[michaelklishin]

Bunny::Queue#pop should use Bunny::MessageProperties. Hash is a leftover from pre-0.9 days.

[mmmries]

Thanks @michaelklishin! I was going to try to reconcile this today at work, but it looks like you beat me to it!