Reset channel unconfirmed_set on network recovery #406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wait_for_confirms for each batch of messages and ensure they have all been confirmed. Ensure all ids get received by subscriber at least once
Unconfirmed messages will never be confirmed by broker after network connection loss. Reset unconfirmed_set on recovery
|
Makes sense. Thank you. |
|
Thanks @michaelklishin for the quick merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With publisher confirms and automatic recovery enabled, when a network failure occurs, acks / nacks no longer get pushed onto the confirms continuations queue. This causes future
wait_for_confirmsto fail, even though the messages published since network recovery have been acknowledged by the broker.I have included a spec with this PR that catches the problem and a fix that resets
unconfirmed_seton network recovery. I tried to keep the stress spec as concise as possible but it does take around 20-30 seconds to run.Any suggestions to improve this are welcome. In particular I wasn't sure whether to put my spec into
spec/issuesinstead.