Treat string and symbols the same when specifying 'server' or :server #524
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I closed the other one as there were conflicts. This is the right one now. |
|
Doh..... clicking too fast. Sorry |
michaelklishin
approved these changes
Oct 24, 2017
|
Thank you. |
|
My pleasure :)
…On 24 Oct 2017 17:33, "Michael Klishin" ***@***.***> wrote:
Thank you.
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<#524 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AB0EctHQD1_yK2JXYWIzr9BgRJqnrlpqks5svgNUgaJpZM4QEmrd>
.
|
michaelklishin
added a commit
that referenced
this pull request
Oct 25, 2017
Contributed by @tyronewilson. Merging with -s ours ignored a commit that should have had no conflicts :/
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When loading config values from yaml file you can't easily pass in a symbol like :server. So this PR treats 'server' the same as :server so that string values can be used from .yml files.