Remove dependency on win32ole
#1051
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will become bundled in Ruby 3.5 Unfortunately there is no portable way of checking for this. The wmic command is deprecated, though I don't observe this myself on W11 (yet?)
Earlopain
force-pushed
the
drop-win32ole
branch
2 times, most recently
from
2c42376
to
6742a0d
Compare
eregon
approved these changes
Jun 7, 2024
|
@MSP-Greg I wonder if you might know what's the best way to get the number of (physical) cores on a Windows machine from Ruby? |
|
The PowerShell command On my system, it shows 10. Do you mean via c code? |
|
I meant via the command-line. |
|
I made a release with this: https://github.com/ruby-concurrency/concurrent-ruby/releases/tag/v1.3.2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will become bundled in Ruby 3.5
Unfortunately there is no portable way of checking for this. The wmic command is deprecated, though I don't observe this myself on W11 (yet?)
Closes #1048
The powershell variant will work in at least releases from 2012 (Windows 8):
https://learn.microsoft.com/en-us/previous-versions/powershell/module/cimcmdlets/get-ciminstance?view=powershell-3.0
https://learn.microsoft.com/en-us/previous-versions/powershell/module/microsoft.powershell.utility/select-object?view=powershell-3.0
https://learn.microsoft.com/en-us/powershell/scripting/install/powershell-support-lifecycle?view=powershell-7.4
There are no docs from earlier so I can't say about versions from before that. Maybe supporting 12 year old versions is good enough and
wmicdoesn't even need to be used? Let me know.This is overall very defensive in what could happen because I'm not primarily developing on windows.