Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix C const comment #1062

Merged
merged 3 commits into from
Dec 6, 2023
Merged

Fix C const comment #1062

merged 3 commits into from
Dec 6, 2023

Conversation

nobu
Copy link
Member

@nobu nobu commented Dec 6, 2023

Fix RDoc::Parser::C#handle_constants.

  • Backslashes here are eaten at parse time, these gsubs do nothing.
  • The content literal in TestRDocParserC#test_do_constants is not using single quotes, so the backslashes are eaten at parse time too and the above bug has not been tested.
  • Limit colon separating the new definition to the first word-ending colon, not to split strings including colons, e.g., URLs and Windows path names.

@nobu nobu merged commit 72c6560 into ruby:master Dec 6, 2023
21 checks passed
@nobu nobu deleted the c-const-comment branch December 6, 2023 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant