Extract excerpt from RDoc::Markup::Document (raw pages) correctly #1200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
st0012
changed the title
colby-swandale
approved these changes
Nov 18, 2024
| @@ -1,7 +1,7 @@ | |||
| # frozen_string_literal: true | |||
| require_relative 'helper' | |||
|
|
|||
| class TestRDocGeneratorDarkfish < RDoc::TestCase | |||
| class RDocGeneratorDarkfishTest < RDoc::TestCase | |||
There was a problem hiding this comment.
This class name change is... unconventional (I looked at the neighboring files). Is it intentional?
There was a problem hiding this comment.
This is intentional because class names should be noun (FooTest) instead of (TestFoo). It also makes them work with ruby-lsp's CodeLens feature.
In IRB I did a big batch of rename so it's been like this in most if not all tests. But given RDoc still has relatively low development activities, I just change them as I touch things.
There was a problem hiding this comment.
@st0012 Thanks for providing that context. Seems like a good thing!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://bugs.ruby-lang.org/issues/20862