This repository has been archived by the owner on Apr 14, 2021. It is now read-only.
Performance fix for MRI 1.9 #1288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MRI 1.9 is considerably faster when directly comparing Gem::Version, while 1.8 is faster with the regex method.
|
👍 Looks good to me! |
|
+1! |
indirect
added a commit
that referenced
this pull request
Aug 9, 2011
--- Make fetch_specs faster fetch_specs merges installed, cached and remote_specs together, using Index.use. Index.use has acceptable performance for small indexes, but when adding a large Index as generated by remote_specs, it takes ages. This change reorders fetch_specs to base its index off of the index generated by remote_specs and then replaces dupes with what cached_specs and installed_specs come up with. Measured timing approximates, with this test program: https://gist.github.com/1067157 MRI 1.8.7 (2010-08-16 patchlevel 302) [x86_64-linux] 1-0-stable 17sec + this 9sec + this + #1288 9sec MRI 1.9.2p0 (2010-08-18 revision 29036) [x86_64-linux] 1-0-stable 11sec + this 6sec + this + #1288 4sec
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I did some testing to cut time for
bundle installruns, and this is one of the low hanging fruits fur Ruby 1.9.Commit text:
MRI 1.9 is considerably faster when directly comparing Gem::Version,
while 1.8 is faster with the regex method.
Tested with:
ruby 1.9.2p0 (2010-08-18 revision 29036) [x86_64-linux]
ruby 1.8.7 (2010-08-16 patchlevel 302) [x86_64-linux]
Rubygems 1.8.5
Test program: https://gist.github.com/1067157
Timings:
1.9 without the change: ~12 sec
1.9 with the change: ~6 sec
1.8 always: ~19 sec