This repository has been archived by the owner on Apr 14, 2021. It is now read-only.
Ensure binstubs generated when using --standalone point to the standalonde bundle #1588
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The binstubs generated by Bundler currently require both rubygems and bundler to be installed in order to execute: requirements not guaranteed at runtime for a standalone bundle.
This introduces a separate method to generate binstubs when generating a standalone bundle. It first adds the root of the standalone to the load path, and then requiring
bundler/setup
from there.I was on the fence whether to leave the load path alone and load bundler/setup.rb directly via its path relative to the generated executeable, but in the end decided to go the way I did so that application code requiring 'bundler/setup' will continue to function.
I'm pretty excited about the standalone feature, and I hope that this makes it into 1.1