This repository has been archived by the owner on Apr 14, 2021. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After running ruby-prof around bundler a few times, I noticed that it was spending a lot of time in
LazySpecification#==
andLockfileParser#parse_spec
. This patch is just a simple refactoring of those two sticky spots to be faster. Additionally, I moved constant strings and regexes into constants to avoid extraneous per-line garbage generation when parsing a lockfile.LazySpecification
now has an#identifier
method that is a memoized hash value of the name, version, source, platform, and dependencies. This gives us a quick way to effectively testeql?
, which has implications in various places.LazySpecification#==
now uses#identifier
rather than building and doing array comparisons.LockfileParser
accumulates specs into a hash keyed by#identifier
rather than testing@specs.include?
for every spec. This reduces the runtime from O(n^2) to O(n log n).All specs pass under Ruby 1.9.3-p327.
To demonstrate the impact, here's my before-and-after times for a production bundle: