Skip to content
This repository has been archived by the owner on Apr 14, 2021. It is now read-only.

Use https:// instead of git:// on GitHub URL's #2569

Merged
merged 1 commit into from
Aug 2, 2013

Conversation

fuadsaud
Copy link
Contributor

See #1820

@gnufied
Copy link
Contributor

gnufied commented Jul 27, 2013

Awesome. thank you so much. While we are at it, can we also update source :rubygems to source "https://rubygems.org" ? It keeps throwing deprecation warnings in spec runs. @fuadsaud

@indirect
Copy link
Member

@gnufied outside the scope of this pull, but fixing deprecations inside our own spec suite sounds like a good idea. :)

@gnufied
Copy link
Contributor

gnufied commented Jul 27, 2013

okay, cool. agreed lets merge this.

@fuadsaud
Copy link
Contributor Author

@gnufied mock calls are also making RSpec go crazy on warnings.

@indirect
Copy link
Member

Separate pull request for that was merged yesterday.

On Mon, Jul 29, 2013 at 11:57 AM, Fuad Saud [email protected]
wrote:

mock calls are also making RSpec go crazy on warnings.

Reply to this email directly or view it on GitHub:
#2569 (comment)

@indirect
Copy link
Member

indirect commented Aug 2, 2013

As far as I can tell, this doesn't break any backwards compatibility, and it is following github's suggestions for more efficient transfer of repos. 👍

indirect added a commit that referenced this pull request Aug 2, 2013
Use https:// instead of git:// on GitHub URL's
@indirect indirect merged commit e2a5d3b into rubygems:master Aug 2, 2013
@fuadsaud fuadsaud deleted the github-https branch August 2, 2013 21:38
@fuadsaud
Copy link
Contributor Author

fuadsaud commented Aug 2, 2013

@indirect nice, thanks!

indirect added a commit that referenced this pull request Aug 16, 2013
This reverts commit e2a5d3b, reversing
changes made to 4353072.

fixes #2600
@jgarber
Copy link

jgarber commented Aug 30, 2013

So, we bundled using 1.4.0.pre.1 and committed the resulting change to Gemfile.lock. Then when we deployed with bundler 1.3.5, we got this:

bundle install --path=vendor/bundle --deployment --without development test cucumber staging production --binstubs ----
STDOUT: You are trying to install in deployment mode after changing
your Gemfile. Run `bundle install` elsewhere and add the
updated Gemfile.lock to version control.

You have added to the Gemfile:
* source: git://github.com/sporkrb/spork-rails.git (at master)
* source: git://github.com/belighted/masq.git (at rails_4)

You have deleted from the Gemfile:
* source: https://github.com/belighted/masq.git (at rails_4)
* source: https://github.com/sporkrb/spork-rails.git (at master)

You have changed in the Gemfile:
* masq from `git://github.com/belighted/masq.git (at rails_4)` to `no specified
source`
* spork-rails from `git://github.com/sporkrb/spork-rails.git (at master)` to `no
specified source`

@indirect
Copy link
Member

Yeah, the change isn't backwards compatible and has been reverted from Bundler 1.4. Please install 1.4.pre.2, which goes back to using git URLs. Bundler 2.0 will make the breaking change to HTTPS.

@jgarber
Copy link

jgarber commented Aug 30, 2013

Awesome! Thanks!

@schlamar
Copy link

schlamar commented Sep 9, 2013

@indirect Ah nice, exactly what I am needing (git port is blocked by proxy). Any ETA for Bundler 2.0?

@indirect
Copy link
Member

indirect commented Sep 9, 2013

you can just use :git => "https..."

On Sun, Sep 8, 2013 at 11:52 PM, Marc Schlaich [email protected]
wrote:

@indirect Ah nice, exactly what I am needing (git port is blocked by proxy). Any ETA for Bundler 2.0?

Reply to this email directly or view it on GitHub:
#2569 (comment)

@schlamar
Copy link

schlamar commented Sep 9, 2013

Yes, I know. But that is not a perfect solution for shared repositories.

@c9s
Copy link

c9s commented Jan 17, 2019

we should allow ssh+git protocol to be configured for GitHub. With https you have to enter the username password for the private repository.
and with ssh+git clone, it is actually faster than https

@rubygems rubygems locked as resolved and limited conversation to collaborators Jan 17, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants