This repository has been archived by the owner on Apr 14, 2021. It is now read-only.
bundler bin for those who confuse it with bundle
#2598
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| ui = Bundler::UI::Shell.new | ||
| ui.error "It's recommended to use Bundler through 'bundle' binary instead 'bundler'" | ||
|
|
||
| Bundler.with_friendly_errors { Bundler::CLI.start } |
There was a problem hiding this comment.
There is still a lot of duplication here. Any way to remove it? If you just exec you probably don't need the check old versions and thor debug stuff.
|
Spec? |
|
@xaviershay updated. I didn't find any specs for |
| ui.error "It's recommended to use Bundler through 'bundle' binary instead of 'bundler'" | ||
|
|
||
| bin = "#{File.dirname(__FILE__)}/bundle #{ARGV.join(" ")}" | ||
| exec "ruby #{bin}" |
There was a problem hiding this comment.
I think the ruby here is redundant? bin/bundle is executable anyways. LGTM otherwise.
|
Re specs, it's probably fine. |
|
@xaviershay fixed. Thanks for the review! |
xaviershay
added a commit
that referenced
this pull request
Aug 16, 2013
`bundler` bin for those who confuse it with `bundle`
|
Merged, thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in rubygems/bundler-features#12, we could provide an executable named "bundler" that prints a warning and silently execs to bundle.