Skip to content
This repository has been archived by the owner on Apr 14, 2021. It is now read-only.

do not request gems declared in gemspec from rubygems #2909

Closed
grosser opened this issue Feb 28, 2014 · 5 comments
Closed

do not request gems declared in gemspec from rubygems #2909

grosser opened this issue Feb 28, 2014 · 5 comments

Comments

@grosser
Copy link
Contributor

grosser commented Feb 28, 2014

I'm building my own little on demand gem server and ran across the issue that bundler always requests the gem it is currently bundling in, and I'd like to avoid that overhead (in this case having to download 1 more github repo) since the information should not be used or necessary.

# Gemfile
source "http://localhost:4567/user"
gemspec
# noooo.gemspec
Gem::Specification.new "noooo", "1.0.0" do |s|
  s.summary = "s"
  s.authors = "a"
end

Resulting request from bundler:
/api/v1/dependencies?gems=noooo

@AlexandreBernard
Copy link

I may have an issue that's similar.

Updating a gem that's on rubygems with a forked one on github for dependency reasons via the git option. I see bundler checking out the gem from github but then it asks me for the old dependencies still.

@indirect
Copy link
Member

indirect commented Mar 8, 2014

That's actually a different issue. Please see ISSUES.

@Who828 Who828 closed this as completed Sep 7, 2014
@grosser
Copy link
Contributor Author

grosser commented Sep 7, 2014

@Who828 did that get solved ?

@dubek
Copy link
Contributor

dubek commented Oct 6, 2014

I made an attempt to solve it in PR #3200 , but I'd like an expert opinion to make sure my change make sense (and doesn't break some other intended behaviour). Comments are welcome.

@grosser
Copy link
Contributor Author

grosser commented Nov 11, 2014

❤️ thx for fixing! :D

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants