Fix rubygems 2.2+ compatibility #3582
Conversation
RubyGems since version 2.2 allows to reconfigure place, where binary extensions are stored. This might allow easier sharing of gems between various Ruby interpreters. It can be enabled by redefining Gem.default_ext_dir_for method. This patch is adding support for this feature into Bundler.
The bang variant returns nil in case there was no change needed.
We don't care about extensions, just about directories. The missing extensions might try to triger rebuild, which fails with "uninitialized constant Gem::UserInteraction" under some versions of RubyGems.
|
Maybe I'm slow, but I'm still not sure what this is fixing. Can you explain why this is needed, now that RubyGems correctly loads .rb and .so files again? |
|
The original explanation is in #3234:
And we are using this feature in Fedora [1]. The attached test case simulates this by the To be precise, it is not about loading, the .rb and .so files are correctly loaded, but the $LOAD_PATH might not be cleaned correctly. This patch set narrows it by using RubyGems facilities. http://pkgs.fedoraproject.org/cgit/ruby.git/tree/operating_system.rb#n103 |
|
Just to give you example, you probably assume that this is the directory structure of RubyGems: while it can be i.e. they don't have common prefix as the current code expects. |
|
Got it. I understand now, thank you for explaining. And thank you for the patch! |
Fix rubygems 2.2+ compatibility
|
Thanks! |
This is follow up of #3237 including the fix to the last test failure on Ruby 1.8.7 and RubyGems 2.2.2.