Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Module#attr_setter does not support frozen-string-literal #286

Open
taichi-ishitani opened this issue Feb 27, 2019 · 0 comments · May be fixed by #287
Open

Module#attr_setter does not support frozen-string-literal #286

taichi-ishitani opened this issue Feb 27, 2019 · 0 comments · May be fixed by #287

Comments

@taichi-ishitani
Copy link

I got the "can't modify frozen String" error when I use the --enable-frozen-string-literal Ruby option.
It is because that Module#attr_setter method does not support frozen-string-literal.

You can see the same error by running commands below

$ export RUBYOPT='--enable-frozen-string-literal'
$ ruby-test test/core/module/test_attr_setter.rb

Then, you will see the error message below

    can't modify frozen String
    C:/Users/ishitani/workspace/facets/lib/core/facets/module/attr_setter.rb:24
    22     code, made = '', []
    23     args.each do |a|
 => 24       code << %{
    25         def #{a}(*args)
    26           args.size > 0 ? ( @#{a}=args[0] ; self ) : @#{a}
    C:/Users/ishitani/workspace/facets/lib/core/facets/module/attr_setter.rb:24
    C:/Users/ishitani/workspace/facets/lib/core/facets/module/attr_setter.rb:23
    test/core/module/test_attr_setter.rb:9
    test/core/module/test_attr_setter.rb:8
    C:/Ruby/Ruby25-x64/lib/ruby/gems/2.5.0/gems/rubytest-cli-0.2.0/lib/rubytest-cli.rb:48
    C:/Ruby/Ruby25-x64/lib/ruby/gems/2.5.0/gems/rubytest-cli-0.2.0/lib/rubytest-cli.rb:18
    C:/Ruby/Ruby25-x64/lib/ruby/gems/2.5.0/gems/rubytest-cli-0.2.0/bin/ruby-test:4
    C:/Ruby/Ruby25-x64/bin/ruby-test:23
taichi-ishitani added a commit to taichi-ishitani/facets that referenced this issue Feb 27, 2019
@taichi-ishitani
Adapt Module#attr_setter to frozen-string-literal (fix rubyworks#286)
17a591f
@taichi-ishitani taichi-ishitani linked a pull request Feb 27, 2019 that will close this issue
Open
taichi-ishitani added a commit to rggen/rggen-core that referenced this issue Feb 27, 2019
@taichi-ishitani
added workaround for following issue
4e924e5 
rubyworks/facets#286
taichi-ishitani added a commit to rggen/rggen-core that referenced this issue Mar 5, 2019
@taichi-ishitani
removed workaround for rubyworks/facets#286
5181ad5
taichi-ishitani added a commit to rggen/rggen-core that referenced this issue Mar 5, 2019
@taichi-ishitani
removed workaround for rubyworks/facets#286
6dff795
taichi-ishitani added a commit to rggen/rggen-core that referenced this issue Mar 5, 2019
@taichi-ishitani
removed workaround for rubyworks/facets#286
2ec2c40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Adapt Module#attr_setter to frozen-string-literal taichi-ishitani/facets
1 participant
@taichi-ishitani