Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Angry Birds Refresh - XML Parser Failure: element is malformed #16862

Closed
Fancy2209 opened this issue Jun 24, 2024 · 4 comments · Fixed by #17050
Closed

Angry Birds Refresh - XML Parser Failure: element is malformed #16862

Fancy2209 opened this issue Jun 24, 2024 · 4 comments · Fixed by #17050
Labels
A-avm2 Area: AVM2 (ActionScript 3) bug Something isn't working xml

Comments

@Fancy2209
Copy link
Contributor

Describe the bug

Angry Birds Refresh fails with

Got "TypeError: Error #1090: XML parser failure: element is malformed.
	at XML/XML::init()
	at XML()
	at com.rovio.factory::XMLFactory$/fromOctetStreamClass()
	at AngryBirdsFacebook/getUIData()
	at AngryBirdsBase()
	at AngryBirdsFacebook()
	at AngryBirdsFacebookCanvas/func2()
	at AngryBirdsFacebookCanvas/init()
	at AngryBirdsFacebookCanvas()" when constructing AVM2 side of movie clip of type AngryBirdsFacebookCanvas

Expected behavior

I'd see the Loading Screen and a Discord Login Popup would show up.

Content Location

https://refresh.teamflashcord.com/

Affected platform

Browser's extension

Operating system

Windows 11

Browser

Mozilla Firefox 127.0.0.1

Additional information

No response

@Fancy2209 Fancy2209 added the bug Something isn't working label Jun 24, 2024
@Lord-McSweeney Lord-McSweeney added A-avm2 Area: AVM2 (ActionScript 3) xml labels Jun 24, 2024
@Fancy2209 Fancy2209 changed the title Angyry Birds Refresh - XML Parser Failure: element is malformed Angry Birds Refresh - XML Parser Failure: element is malformed Jun 30, 2024
@evilpie
Copy link
Collaborator

evilpie commented Jun 30, 2024

The problem is this invalid piece of XML:

    <PopupView_Embed name="EmbedLevel" fromLibrary="True"
      overlay="True" width="1024" height="768" alignH="CENTER" alignV="CENTER">
    </PopupView_Embed scaleH="UP" scaleV="UP" aspectRatioFixed="TRUE" >

Note the unexpected attributes in the closing tag.

@ultra0000
Copy link

An update will be pushed soon to fix this:
image
Should this issue be kept open? Also, there's another issue happening during loading where the game doesn't get its login data through ExternalInterface, should I open an issue for that too?

@evilpie
Copy link
Collaborator

evilpie commented Jun 30, 2024

We can keep this open until we accept this bad syntax in Ruffle. Please open a new issue for the new ExternalInterface issue.

@Fancy2209
Copy link
Contributor Author

We can keep this open until we accept this bad syntax in Ruffle. Please open a new issue for the new ExternalInterface issue.

#16942 was opened for this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-avm2 Area: AVM2 (ActionScript 3) bug Something isn't working xml
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants