Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NuGet package missing assembly #28

Open
mguinness opened this issue Jan 22, 2021 · 4 comments
Open

NuGet package missing assembly #28

mguinness opened this issue Jan 22, 2021 · 4 comments

Comments

@mguinness
Copy link

Thanks for creating a great library. I tried to use the NuGet package at https://www.nuget.org/packages/MRE/ but it doesn't include an assembly (only the source code) which limits it's usability. Can a new package be published that includes an assembly? Thanks in advance.

@mguinness
Copy link
Author

I think this can be achieved by modifying CreatePackage.bat to below. I have an ASP.NET Core project that I'd like to include this in and I think there would be others that would find this useful too. I'll share the repo here after it's created as it demonstrates the power of BRE in an application and might help popularize this excellent library.

mkdir lib
mkdir lib\net461
mkdir lib\netstandard2.1
mkdir content
mkdir content\MRE

copy ..\MicroRuleEngine\bin\Release\net461 lib\net461
copy ..\MicroRuleEngine\bin\Release\netstandard2.1 lib\netstandard2.1
copy ..\MicroRuleEngine\MRE.cs content\MRE

nuget pack MRE.nuspec -Exclude *.bat
nuget push MRE.1.0.4.nupkg -Source https://api.nuget.org/v3/index.json
pause

@mguinness
Copy link
Author

@runxc1 Another option is to Publish NuGet package with GitHub Actions instead of using a batch file. One benefit would be that updated packages can be pushed to NuGet by repo contributors if you are busy/unavailable.

@runxc1
Copy link
Owner

runxc1 commented Jan 27, 2021

So I wouldn't be opposed to having a separate Nuget that contains a compiled version of the MRE for those that need it but probably wouldn't want to alter the current package.

@mguinness
Copy link
Author

Thanks for your reply. I've just asked the package owner of MicroRuleEngine (which is no longer used) if they would add another owner so that a new package can be published there.

Could you explain how the existing package is used? My understanding it that the initial install copies the MRE.cs file into the project, but doesn't for subsequent package updates.

I tried this using VS 2019 in a new .NET Core project, but the MRE.cs was never copied into the project - it appears a NuGet change for Content Files stops this from happening?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants