Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

depends on deprecated serde_yaml (maybe move to serde_yml?) #103

Closed
dkg opened this issue Sep 9, 2024 · 2 comments
Closed

depends on deprecated serde_yaml (maybe move to serde_yml?) #103

dkg opened this issue Sep 9, 2024 · 2 comments

Comments

@dkg
Copy link

dkg commented Sep 9, 2024

I noticed that one of the dependencies for confy is the serde_yaml crate which has been explicitly deprecated as unmaintained upstream. Perhaps confy should switch to serde_yml or something similar instead, for its yaml support?

@Zykino
Copy link
Contributor

Zykino commented Sep 9, 2024

Already discussed in #100

@deg4uss3r
Copy link
Contributor

Hello! Yes as @Zykino mentioned I address this in #100. For completeness I'll also add my thoughts here.

I want to keep our current crate for a couple reasons.

  1. We have had that crate the entire length of this project and have had no issues
  2. The updated serde_yml is still under a sole maintainer
  3. The yaml spec in its lifetime won't benefit much from moving the crate (e.g. there won't be new features or changes to yaml)
  4. We now have a reoccurring audit job to warn us of any vulnerabilities (and in addition other unmaintained crates, as tradition is not good practice)

The last point being the most important, if the audit job uncovers anything with serde_yaml then we'd move immediately.

However, if any thing changes or that crate does end up getting significant feature updates that are attractive to this library we can reopen this issue and consider.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants