Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Binary support? #33

Open
cheako opened this issue Jan 17, 2021 · 4 comments
Open

Binary support? #33

cheako opened this issue Jan 17, 2021 · 4 comments
Labels
enhancement Improve the expected

Comments

@cheako
Copy link

cheako commented Jan 17, 2021

Some binary data cannot be represented in an &str, so functions that take &[u8] are necessary. Unless I misunderstand or am using the wrong tool.

Use case is programing Marvell ARMADA 3700 over serial port.
@cheako
Copy link
Author

cheako commented Jan 17, 2021

Looking at this I can't believe this does not panic when reading half of an unicode char?

@cheako
Copy link
Author

cheako commented Jan 20, 2021

https://github.com/cheako/rexpect/tree/binary

@philippkeller
Copy link
Collaborator

thanks for reporting this. It looks like you are trying to come up with a pull request. Is this correct?
I have very limited time for this project. If you issue a PR and it passes the tests and examples I will merge it

@cheako
Copy link
Author

cheako commented Jan 20, 2021

Much more testing is needed, but thanks for doing what you can to maintain this.

@epage epage added the enhancement Improve the expected label Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Improve the expected
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@philippkeller @epage @cheako