Feature gate local echo. #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eldruin
reviewed
Jan 16, 2023
|
It took me a long time to come back to this. It's done! |
eldruin
reviewed
Mar 15, 2023
|
Done! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
I'd like to propose adding a feature gate that disables local echo.
To implement this, I've added a new
no-echofeature flag to theCargo.tomlfile and wrapped the relevant code in an#[cfg(not(feature = "no-echo"))]block. I've also added code to write the whole command after a carriage-return is a sent. This is wrapped in an#[cfg(feature = "no-echo")].I believe this feature will be useful for users who want to disable local echo in certain cases (when using menu with RTT transport for ex.). Please let me know if you have any questions or concerns.
Thank you!