Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot specify timings in .cargo/config #10509

Closed
jerryc05 opened this issue Mar 26, 2022 · 8 comments
Closed

Cannot specify timings in .cargo/config #10509

jerryc05 opened this issue Mar 26, 2022 · 8 comments
Assignees
Labels
A-configuration Area: cargo config files and env vars A-timings Area: timings C-bug Category: bug S-accepted Status: Issue or feature is accepted, and has a team member available to help mentor or review

Comments

@jerryc05
Copy link

jerryc05 commented Mar 26, 2022

Problem

Cannot specify timings option in .cargo/config

Steps

  1. Add these to .cargo/config:
    [build]
    timings = ['html']
    
  2. Shows warning: warning: unused config key build.timings, and timings not activated.

Possible Solution(s)

Parse build.timings in .cargo/config since timings is removed from unstable in nightly cargo.

Notes

No response

Version

cargo 1.61.0-nightly (109bfbd 2022-03-17)
release: 1.61.0-nightly
commit-hash: 109bfbd055325ef87a6e7f63d67da7e838f8300b
commit-date: 2022-03-17
host: x86_64-unknown-linux-gnu
libgit2: 1.4.2 (sys:0.14.2 vendored)
libcurl: 7.80.0-DEV (sys:0.4.51+curl-7.80.0 vendored ssl:OpenSSL/1.1.1m)
os: Debian unstable (sid) [64-bit]


<!-- TRIAGEBOT_START -->

<!-- TRIAGEBOT_ASSIGN_START -->

<!-- TRIAGEBOT_ASSIGN_DATA_START$${"user":"hi-rustin"}$$TRIAGEBOT_ASSIGN_DATA_END -->

<!-- TRIAGEBOT_ASSIGN_END -->
<!-- TRIAGEBOT_END -->
@jerryc05 jerryc05 added the C-bug Category: bug label Mar 26, 2022
@weihanglo weihanglo added A-configuration Area: cargo config files and env vars A-timings Area: timings labels Mar 28, 2022
@Rustin170506
Copy link
Member

@weihanglo @ehuss Is this acceptable? I think I can help to add it.

@ehuss
Copy link
Contributor

ehuss commented Apr 5, 2022

Seems like a reasonable addition to me. Roughly the things that need to be done to add this are:

@ehuss ehuss added the S-accepted Status: Issue or feature is accepted, and has a team member available to help mentor or review label Apr 5, 2022
@Rustin170506
Copy link
Member

@rustbot claim

@epage
Copy link
Contributor

epage commented Jul 5, 2022

@jerryc05 could you expand on why you are interested in this being in the config? This seems like a transient option for me and the use case for making it more permanent in a file seems unclear.

@Rustin170506
Copy link
Member

@jerryc05 Friendly ping~

Could you share your use cases?

@jerryc05
Copy link
Author

jerryc05 commented Aug 5, 2022

Ummm its been a long time since I coded in Rust. I guess I was building my Rust coding starter template at that time and would like to have all my options setup in one config file instead of passing arguments.

@Rustin170506
Copy link
Member

@epage Maybe we can close this issue now? I think there are no reasonable use cases for this config. Because it's a debugging config, we can always pass it.

@epage
Copy link
Contributor

epage commented Aug 23, 2022

I'm not quite seeing why this would be put in a starter template as it seems like you wouldn't want timings on every run but only when specifically wanting to measure a build.

If someone does come up with a reason for wanting timings on every run, we can reconsider this. For now, I'm going to close this though as there doesn't seem to be sufficient motivation provided.

@epage epage closed this as not planned Won't fix, can't repro, duplicate, stale Aug 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-configuration Area: cargo config files and env vars A-timings Area: timings C-bug Category: bug S-accepted Status: Issue or feature is accepted, and has a team member available to help mentor or review
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants