Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider upgrading criterion to 0.4.0, removing html_reports and switching to cargo criterion #12081

Open
Muscraft opened this issue May 3, 2023 · 1 comment
Labels
A-testing-cargo-itself Area: cargo's tests C-enhancement Category: enhancement S-triage Status: This issue is waiting on initial triage.

Comments

@Muscraft
Copy link
Member

Muscraft commented May 3, 2023

Motivation

In #12057, it was noted that the comment "Consider removing html_reports in 0.4 and switching to cargo criterion", should probably have an issue opened for it.

Notes

criterion 0.4.0 was released on Sep 10, 2022 (changelog), so it should be safe to move to. There is a getting started section in the book, which should help with the move. For information about the cargo subcommand cargo-criterion see this section in the book, or the repository.

It should be noted that the information in the contributor guide and the README for benches will need to be updated to reflect these changes.

@Muscraft Muscraft added C-enhancement Category: enhancement A-testing-cargo-itself Area: cargo's tests labels May 3, 2023
@ehuss
Copy link
Contributor

ehuss commented May 3, 2023

This has me a little concerned: cargo-criterion does not currently support baselines

I'm not sure why that means exactly, but establishing baselines is fundamental to comparing changes. Someone will need to investigate what the process is for generating an HTML report after saving a baseline, and whether or not that still requires the html_reports feature.

@epage epage added the S-triage Status: This issue is waiting on initial triage. label Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-testing-cargo-itself Area: cargo's tests C-enhancement Category: enhancement S-triage Status: This issue is waiting on initial triage.
Projects
None yet
Development

No branches or pull requests

3 participants