-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature request: applying icons to binary targets #2475
Comments
This would probably be best suited as some form of post-build-system after Cargo. You're right in that Cargo largely just talks to rustc itself, and this sounds like it may not interact much with the compiler? |
@alexcrichton That is correct. For example, in Windows we would talk to MSVC instead of |
I think this could be easily integrated as a subcommand, yeah! |
I unfortunately don't have much knowledge about how Cargo works internally, so I don't know how useful I can be with implementation. However, I can certainly help with testing, especially on Linux. Here are two reference links detailing how the |
The simplest way to add an icon seems to be through a resource file, and this could be handled through As for the desktop entry, there seems to be a @alexcrichton should these features be added to Cargo or kept external? |
If it's possible to do this via an external crate then that is best. |
As the discussion is focused on this being implemented via third-party support, whether an external subcommand or #545, I'm going to close as there isn't anything actionable for cargo itself. If there is a reason for us to re-evaluate this, let us know! |
I would like to see support for applying icons to binary targets. Perhaps this could be added as an extra configuration switch under
[[bin]]
. If set, binaries targeting Windows would have the given icon file applied through a resource file, while Linux binaries could have a*.desktop
file generated that could be placed in/usr/share/applications
. I am not familiar enough with OS X to comment on how application icons are assigned to binaries.I know that this feature is supported by CMake but is largely handled by the platform's available toolchain. Cargo can only interact with
rustc
AFAIK, so I presume we are limited by the capabilities of the compiler. How feasible would this be?The text was updated successfully, but these errors were encountered: