Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

exclude key of package section is ignored when submodule is involved #4319

Closed
BusyJay opened this issue Jul 23, 2017 · 3 comments
Closed

exclude key of package section is ignored when submodule is involved #4319

BusyJay opened this issue Jul 23, 2017 · 3 comments

Comments

@BusyJay
Copy link
Contributor

BusyJay commented Jul 23, 2017

When the directory excluded is part of a git submodule (or even the submodule itself), cargo package will still include them in the generated crate file.

@alexcrichton
Copy link
Member

cc @behnam

@BusyJay
Copy link
Contributor Author

BusyJay commented Jul 24, 2017

I made a mistake, I thought that cargo treat the path the same way as .gitignore, but it turns out it's treated as a globs pattern. Sorry for the carelessness.

@BusyJay BusyJay closed this as completed Jul 24, 2017
@behnam
Copy link
Contributor

behnam commented Jul 24, 2017

Right, @BusyJay, at the moment we're matching them as glob patterns.

But, we are changing that behavior and want to stay as close to gitignore as possible. Please see these discussions for more info:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants