From e9f8458d9e2b1cfeb02ec8fe960eceac15141c66 Mon Sep 17 00:00:00 2001 From: Kazuyoshi Kato Date: Sat, 7 Sep 2019 23:04:54 -0700 Subject: [PATCH 1/2] Fix indentation --- app/mixins/rl-dropdown-component.js | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/app/mixins/rl-dropdown-component.js b/app/mixins/rl-dropdown-component.js index 1d9adf352d..428c92efcd 100644 --- a/app/mixins/rl-dropdown-component.js +++ b/app/mixins/rl-dropdown-component.js @@ -60,8 +60,8 @@ export default Mixin.create({ if (this.dropdownExpanded) { /* Add clickout handler with 1ms delay, to allow opening the dropdown - * by clicking e.g. a checkbox and binding to dropdownExpanded, without - * having the handler close the dropdown immediately. */ + * by clicking e.g. a checkbox and binding to dropdownExpanded, without + * having the handler close the dropdown immediately. */ later(() => { $document.bind(clickEventName, { component }, component.boundClickoutHandler); $document.bind(focusEventName, { component }, component.boundClickoutHandler); @@ -96,13 +96,13 @@ export default Mixin.create({ let $target = $(event.target); /* There is an issue when the click triggered a dom change in the - * dropdown that unloaded the target element. The ancestry of the target - * can no longer be determined. We can check if html is still an ancestor - * to determine if this has happened. The safe option then seems to be to - * not close the dropdown, as occasionaly not closing the dropdown when it - * should have closed, seems to be less bad for usability than occasionaly - * closing the dropdown when it should not have closed. - */ + * dropdown that unloaded the target element. The ancestry of the target + * can no longer be determined. We can check if html is still an ancestor + * to determine if this has happened. The safe option then seems to be to + * not close the dropdown, as occasionaly not closing the dropdown when it + * should have closed, seems to be less bad for usability than occasionaly + * closing the dropdown when it should not have closed. + */ if ( component.get('dropdownExpanded') && $target.closest('html').length && From f9534513aa3bc40a188c3513a621b4d8551651bf Mon Sep 17 00:00:00 2001 From: Kazuyoshi Kato Date: Sat, 7 Sep 2019 23:09:42 -0700 Subject: [PATCH 2/2] Remove unnecessary rules --- .eslintrc.js | 8 -------- 1 file changed, 8 deletions(-) diff --git a/.eslintrc.js b/.eslintrc.js index 2f470003ad..adc0d8ff90 100644 --- a/.eslintrc.js +++ b/.eslintrc.js @@ -11,14 +11,6 @@ module.exports = { }, rules: { 'prettier/prettier': 'error', - - 'arrow-parens': 'off', - 'brace-style': 'off', - camelcase: 'off', - 'comma-dangle': 'off', - 'dot-notation': 'off', - 'operator-linebreak': 'off', - 'ember/no-observers': 'warn', 'ember/no-new-mixins': 'warn', 'ember/require-return-from-computed': 'warn',