-
Notifications
You must be signed in to change notification settings - Fork 605
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use fastboot #204
Comments
The whole front-end is using Ember.js (if I am not mistaken). It may not be animated but it makes extensive use of Javascript to render the pages. |
yes, exactly my point, its using javascript where static pages would be the tool of choice. |
I agree that most parts of the page could and should probably be rendered server-side and only use JavaScript to enhance the page with animations, graphics, ... This is probably not going to change at the moment but it's worth remembering when Crates.io get's its redesign. @alexcrichton can probably make a more "official" comment though :) |
When FastBoot lands, we'll get server-side stuff with no code changes, just some ops ones. Sent from my iPhone
|
While I have no problem with needing JavaScript, the page sometimes renders slow and uses a lot of CPU when loading. It would be nice if a beefy server did the rendering instead of the client. |
its not even like doing that stuff on the server would be costly, you can render it once and cache the results until its updated the next time which i guess is a timespan of about 2 months for an average crate, maybe less often. |
I tried a preview of FastBoot today, but it's gonna require something like Ember 2.3.x, so we would have to upgrade before using it. |
What's the status on this? Can we help with activating FastBoot for crates.io, is there anything that needs to be done? |
Fastboot is very close, but not quite done: https://www.npmjs.com/package/fastboot
|
i am not too confident fastboot will ever land, its now almost a year later, and they have reached rc-6 development is slow: https://github.com/ember-fastboot/fastboot/commits/master and issues are plentiful: ember-fastboot/ember-cli-fastboot#360 this might not be the way to go for allowing people to view static content without javascript. |
|
If hex.pm can manage to not rely on JavaScript, there should be no technical reason crates.io cannot, right? Edit: rewritten in a less inflammatory way. |
@nox We're working on it! Unfortunately, everyone working on crates.io is a volunteer, so these things take time. Thank you for your patience! |
@carols10cents Didn't see your answer earlier. ACK, and I'll sit in a corner and wait patiently. |
ok, so fastboot has now landed, what can i do to help enable people to view static content without executing a turing complete language on their mobile cpus? |
@carols10cents next step would be to cleanup and finish #819 in some way. unfortunately my dayjob keeps me pretty busy at the moment, but I'll try to have a look at it when I find a bit of time... 😞 |
I've also been busy with work, and I believe that's also true for @sivakumar-kailasam. It's still on my mind! |
I have a mini vacation coming up in a couple of weeks. I hope to revisit this then. |
I've taken another look, and it seems one of the main issues that is preventing this so far is our use of localstorage to keep session data. It would be great if we could use https://github.com/simplabs/ember-simple-auth and/or https://github.com/Vestorly/torii for the GitHub login flow, but it seems that our use of their OAuth system doesn't match how torii is designed to do it. Is there documentation somewhere that details on how authentication with crates.io works or is supposed to work? |
Even if auth doesn't work without JS, it will still be a huge improvement. Would that be easier to implement? |
I've created a proof of concept PR to show how Crates.io could be rendered server-side: #1173 |
Any news on that? |
@nox we (Ember community peeps) got busy with life stuff :/ Coincidentally I was going to try updating the Ember dependencies today. I'll see if I can kickstart the efforts again. |
Due to the sluggishness I've started to avoid crates.io and instead I'm using a self-written, self-hosted alternative. It's much leaner and faster than crates.io, even if it adopts fastboot one day. It only has the things that I need and lacks some things that might be needed for a full crates.io replacement, but I'm happy. https://gitlab.com/est/cargo-local-serve |
I'm going to submit a few small PRs to remove jQuery from here and there. https://github.com/ember-fastboot/ember-cli-fastboot#no-jquery
Here is the first one: #1714 |
And the second one: #1715 |
Work is currently being tracked at #1811 :) |
I mean its bascially a static site, nothing animated.
Why does it have to use javascript? For that sweet asynchronous loading? I don't think thats worth it.
The text was updated successfully, but these errors were encountered: