Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong --extern-html-root-url key used #1166

Closed
Nemo157 opened this issue Nov 5, 2020 · 1 comment · Fixed by #1188
Closed

Wrong --extern-html-root-url key used #1166

Nemo157 opened this issue Nov 5, 2020 · 1 comment · Fixed by #1188
Labels
A-builds Area: Building the documentation for a crate C-bug Category: This is a bug

Comments

@Nemo157
Copy link
Member

Nemo157 commented Nov 5, 2020

dep.name.replace("-", "_"),

This should almost certainly be dep.library_name() or something similar, to handle dependencies which rename their library (I don't know of any example build logs to see if it's an issue though). See rust-lang/rust#76296 as well, we can't actually give a unique name here when things like duplicate renamed dependencies come into play.

@jyn514 jyn514 added A-builds Area: Building the documentation for a crate C-bug Category: This is a bug labels Nov 6, 2020
@jyn514
Copy link
Member

jyn514 commented Nov 6, 2020

Rustdoc expects the library name anyway, we can't do anything about that until rust-lang/rust#76296 is fixed. We definitely shouldn't be using .replace() though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-builds Area: Building the documentation for a crate C-bug Category: This is a bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants