Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken link to external crate source file #420

Closed
pickfire opened this issue Oct 2, 2019 · 8 comments
Closed

Broken link to external crate source file #420

pickfire opened this issue Oct 2, 2019 · 8 comments

Comments

@pickfire
Copy link
Contributor

pickfire commented Oct 2, 2019

In https://docs.rs/tokio/0.2.0-alpha.6/tokio/attr.main.html, [src] redirected to https://docs.rs/tokio-macros/0.2.0-alpha.6/src/tokio_macros/lib.rs.html#48-120 which gives 404.

Probably related to

docs.rs/src/web/mod.rs

Lines 182 to 190 in 32074e7

router.get("/:crate/:version/:target",
rustdoc::rustdoc_redirector_handler,
"crate_version_target");
router.get("/:crate/:version/:target/",
rustdoc::rustdoc_html_server_handler,
"crate_version_target_");
router.get("/:crate/:version/:target/*.html",
rustdoc::rustdoc_html_server_handler,
"crate_version_target_html");

@Nemo157
Copy link
Member

Nemo157 commented Oct 4, 2019

This could be related to #298

@jyn514
Copy link
Member

jyn514 commented Dec 7, 2019

This may have been fixed in #487 ... If not the fix would be very similar

@pickfire
Copy link
Contributor Author

pickfire commented Dec 7, 2019

I think that probably have not fixed it (not tested) since https://docs.rs/tokio-macros/0.2.0-alpha.6/src/tokio_macros/lib.rs.html#48-120 will be https://docs.rs/crate/tokio-macros/0.2.0/source/src/lib.rs, not sure why backward-compatibility for docs.rs is broken, IIRC source was not there.

@jyn514
Copy link
Member

jyn514 commented Dec 7, 2019

Actually looking at the crate it's because tokio-macros doesn't have documentation (#422, should be fixed by #491). Do you have any other examples of broken links? If not I think this should be closed.

@pickfire
Copy link
Contributor Author

pickfire commented Dec 8, 2019

It does not have documentation but I mean the source link is broken, not the documentation link. See https://docs.rs/tokio/0.2.0-alpha.6/tokio/attr.main.html

@jyn514
Copy link
Member

jyn514 commented Dec 8, 2019

I'm not quite sure what you're saying. That page links to https://docs.rs/tokio-macros/0.2.0-alpha.6/src/tokio_macros/lib.rs.html#48-120 which seems reasonable. What do you think it should link to?

@pickfire
Copy link
Contributor Author

pickfire commented Dec 9, 2019

Yes, exactly. https://docs.rs/tokio-macros/0.2.0-alpha.6/src/tokio_macros/lib.rs.html#48-120 shows the resource does not exist.

@jyn514
Copy link
Member

jyn514 commented Dec 9, 2019

We're going in circles here.

it's because tokio-macros doesn't have documentation (#422, should be fixed by #491).

If you go to 0.2.0 it works fine, pietro queued a rebuild and it's live.

@jyn514 jyn514 closed this as completed Dec 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants