Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing documentation, possibly due to package renaming #477

Closed
alecmocatta opened this issue Nov 15, 2019 · 8 comments · Fixed by #487
Closed

Missing documentation, possibly due to package renaming #477

alecmocatta opened this issue Nov 15, 2019 · 8 comments · Fixed by #487
Labels
C-build-failure Category: This is a crate that failed to build

Comments

@alecmocatta
Copy link

Crate name:
constellation-rs

Build failure link:
https://docs.rs/crate/constellation-rs/0.1.8
"constellation-rs-0.1.8 doesn't have any documentation."

Additional details:
The crate is substantially unchanged since v0.1.6 which built documentation correctly in September: https://docs.rs/crate/constellation-rs/0.1.6

My other crates crates are building fine; the only out of the ordinary thing about this crate is probably this in the Cargo.toml:

[lib]
name = "constellation"

From a cursory glance this might be the issue:

has_docs = build
.host_target_dir()
.join(&res.target)
.join("doc")
.join(name.replace("-", "_"))
.is_dir();

Perhaps instead of the crate name it should test if any of the package names exist as directories?

@alecmocatta alecmocatta added the C-build-failure Category: This is a crate that failed to build label Nov 15, 2019
@jyn514
Copy link
Member

jyn514 commented Nov 15, 2019

Build log: https://docs.rs/crate/constellation-rs/0.1.8/builds/198779

This doesn't appear to be a sandboxing issue, there's no errors in the build.

@jyn514
Copy link
Member

jyn514 commented Nov 15, 2019

Ah I missed where you said that the lib name differed from the crate name, that's probably it.

@GuyL99
Copy link

GuyL99 commented Nov 22, 2019

I think my crate encounters the same problem:
https://crates.io/crates/metropolis
Do you have any solution to this problem?

@pietroalbini
Copy link
Member

Opened a PR to fix the underlying issue: #487

@pietroalbini
Copy link
Member

@alecmocatta @GuyL99 scheduled a rebuild of constellation-rs 0.1.8 and metropolis 0.3.2. Please let me know if you need to build more crates.

@zao
Copy link

zao commented Nov 25, 2019

@pietroalbini I didn't bother mention my crate as I assumed that everything that missed docs would be rebuilt automagically. I've got serpent-cipher 0.1.2 suffering from the same problem.

@pietroalbini
Copy link
Member

@zao just queued a rebuild.

@jyn514
Copy link
Member

jyn514 commented Nov 25, 2019

@zao rebuilding automagically is #464

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-build-failure Category: This is a crate that failed to build
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants