Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rollup=iffy #93

Closed
Manishearth opened this issue Jul 9, 2020 · 1 comment · Fixed by #94
Closed

Add rollup=iffy #93

Manishearth opened this issue Jul 9, 2020 · 1 comment · Fixed by #94

Comments

@Manishearth
Copy link
Member

Overall when making rollups I roughly categorize PRs into four categories: never, always, iffy, and normal:

  • Never PRs are marked rollup=never and should never be rolled up.
  • Always PRs are either marked rollup=always or should be and contain changes that are unlikely to break tests.
  • Iffy vs normal is a judgement call I make: normal ones are ones which are unlikely to cause issues, whereas iffy ones are ones which e.g. make changes to codegen, platform stuff, or the build system.

It would be nice if homu had an extra category for this and sorted the PRs appropriately.

When I make rollups, I try to include some iffy PRs, but I try to limit it.

@Manishearth
Copy link
Member Author

Actually, while we're at this we should prioritize rollup=never>iffy>none>always

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant