Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter out small items from summarize table #32

Closed
Darksonn opened this issue Apr 25, 2019 · 1 comment · Fixed by #36
Closed

Filter out small items from summarize table #32

Darksonn opened this issue Apr 25, 2019 · 1 comment · Fixed by #36
Labels
T-summarize Related to the summarize tool

Comments

@Darksonn
Copy link
Contributor

Since the table printed by summarize is intended to be read by humans, we should avoid printing every simple item, since it results in many lines of output (1000 lines for the regex crate).

I propose to provide a parameter to filter lines, so only those items worth more than some percentage of the total runtime are shown. (or similar)

As for choosing a default value, one should probably experiment a bit to figure out where the long tail is. For reference the items with runtime > 1% are 76% of the total runtime on the regex crate.

@wesleywiser wesleywiser added the T-summarize Related to the summarize tool label Apr 25, 2019
@amanjeev
Copy link
Member

I will take a shot at this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-summarize Related to the summarize tool
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants