-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make measureme tools available as rustup component #64
Comments
That seems correct to me but I don't know much about rustup components. |
I think this is probably the best best, yes, though I think if we're to do this we'll want to always ship measureme (like Cargo, not like RLS/Clippy) and probably also run some tests. For perf, at least, it's really important that self profile works reliably if we're to have it. |
Good point, @Mark-Simulacrum. Having it in-tree in some form will make testing easier. |
I'm wondering two things regarding this:
|
We initially had analysis inside of |
The measureme version in the compiler and the corresponding tools must stay in sync in order for things to be really reliable. I suspect that the best way of doing this in the
rustc
ecosystem is to make the measureme suite available as a rustup component. This would have the following benefits:@Mark-Simulacrum & @wesleywiser, do you agree that the rustup component would actually have these benefits? (My knowledge about rustup components is mostly accidental)
I assume that measureme would have to be part of the main Rust repository somehow (as a submodule probably), which seems fine.
The text was updated successfully, but these errors were encountered: