Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

convert intrinsic shims to intrinsics with fallback bodies #3302

Open
oli-obk opened this issue Feb 16, 2024 · 2 comments
Open

convert intrinsic shims to intrinsics with fallback bodies #3302

oli-obk opened this issue Feb 16, 2024 · 2 comments
Labels
A-intrinsics Area: Affects out implementation of Rust intrinsics C-cleanup Category: cleaning up our code

Comments

@oli-obk
Copy link
Contributor

oli-obk commented Feb 16, 2024

Now that rustc supports rust-lang/rust#93145 we can add support for it to miri and start removing some shims, writing them in pure rust in libcore instead
@RalfJung
Copy link
Member

Note that this is only okay if the fallback body has exactly as much UB as the specification of the intrinsic permits.

We need to make sure that we don't accidentally run a fallback body that fails to detect some UB.

@oli-obk
Copy link
Contributor Author

oli-obk commented Apr 23, 2024

blocked on #3397

@RalfJung RalfJung added A-shims Area: This affects the external function shims C-cleanup Category: cleaning up our code labels May 3, 2024
@RalfJung RalfJung mentioned this issue May 3, 2024
Closed
@RalfJung RalfJung added A-intrinsics Area: Affects out implementation of Rust intrinsics and removed A-shims Area: This affects the external function shims labels May 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-intrinsics Area: Affects out implementation of Rust intrinsics C-cleanup Category: cleaning up our code
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@RalfJung @oli-obk