Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate crate categories and allow metadata on keywords #3488
base: master
Are you sure you want to change the base?
Deprecate crate categories and allow metadata on keywords #3488
Changes from 1 commit
83be1e5
a9116dc
c24e1a3
c0f518d
36aab72
0dead27
059d749
7d66e0c
5a23553
f7c36d7
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not convinced that we necessary need the colon support in tags. If we put that kind of meaning to it, it would probably have to be supported on the crates.io backend and I see that as potentially challenging if we allow users to invent new tags.
I also don't really see the need for it since
#development-tools::testing
could be replaced by#development-tools #testing
and most likely still work equally well.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel like nesting is helpful to know what is an intentional refinement of a tag when browsing blessed tags like browsing the development-tools category
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure I completely understand this part. Could you add an example for this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
crates.io choosing which tags are "noteworthy" doesn't seem all that different from crates.io choosing which categories can be created.
To me this seems to be mainly a matter of creating a policy and a process, whether you call that categories or noteworthy tags.
New categories could be picked based on popularity of keywords.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right, the main issue with that model is that if new categories are picked based upon keywords, users now have to upload new versions of their crates that use those categories. If keywords themselves can be treated as categories, those changes are applied retroactively.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only so far as they picked the "winners". With all of the different cases, etc, I still seeing all but a select few influential packages as having to make a change and do a new release.