Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flycheck error message not logged #16969

Closed
Noratrieb opened this issue Mar 28, 2024 · 0 comments · Fixed by #17033
Closed

Flycheck error message not logged #16969

Noratrieb opened this issue Mar 28, 2024 · 0 comments · Fixed by #17033
Labels
A-flycheck issues with flycheck a.k.a. "check on save" C-feature Category: feature request E-easy

Comments

@Noratrieb
Copy link
Member

In everyone's favourite workspace, I made bootstrap sad, causing the flycheck invocation to fail (unrelated to r-a).
I noticed this because r-a wasn't giving suggestion and the big warning sign was shown. Indeed, the logs confirmed this:

2024-03-28T19:01:16.007328Z ERROR flycheck: Flycheck failed to run the following command: CommandHandle { program: "python3", arguments: ["x.py", "check", "--json-output", "--build-dir", "build-rust-analyzer"], current_dir: Some("/home/nils/projects/rust2") }
2024-03-28T19:01:18.554495Z ERROR flycheck: Flycheck failed to run the following command: CommandHandle { program: "python3", arguments: ["x.py", "check", "--json-output", "--build-dir", "build-rust-analyzer"], current_dir: Some("/home/nils/projects/rust2") }
2024-03-28T19:01:20.449995Z ERROR flycheck: Flycheck failed to run the following command: CommandHandle { program: "python3", arguments: ["x.py", "check", "--json-output", "--build-dir", "build-rust-analyzer"], current_dir: Some("/home/nils/projects/rust2") }

Sadly, by default it does not show the standard output of the flycheck command, making it annoying try to figure out what happened (I had to copy the command and clean it up manually to figure out what went wrong (and then fix it).
If r-a just logged standard error of the command, it would have been easier to see what's wrong.

Bonus: if r-a used <std::process::Command as Debug>, it would actually show a very pretty copy-able command invocation :)

@Noratrieb Noratrieb added the C-feature Category: feature request label Mar 28, 2024
@lnicola lnicola added the A-flycheck issues with flycheck a.k.a. "check on save" label Mar 28, 2024
@Veykril Veykril added the E-easy label Mar 28, 2024
@bors bors closed this as completed in 657b33b Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-flycheck issues with flycheck a.k.a. "check on save" C-feature Category: feature request E-easy
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants