don't emit #[repr(align(0))] for empty unions #1595
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
emilio
approved these changes
Jul 21, 2019
src/ir/comp.rs
Outdated
| @@ -1078,8 +1078,13 @@ impl CompInfo { | |||
| return None; | |||
| } | |||
|
|
|||
| if self.kind == CompKind::Union && self.fields().len() == 0 { | |||
There was a problem hiding this comment.
nit: No need for self.kind == CompKind::Union, since we early-return for struts before.
Also, self.fields().is_empty().
| let mut max_size = 0; | ||
| let mut max_align = 0; |
There was a problem hiding this comment.
Instead, we should probably return None if we didn't find any of the field layouts, but this is fine too I think.
There was a problem hiding this comment.
returning None if none the field fields have a layout cause theses tests to fail internally with 'Unable to get layout information?', so leaving this as-is for now.
header_issue_493_1_0_hpp
header_issue_493_hpp
header_transform_op_hpp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1565.
Add a test case for the real root cause of #1565.
Update a few apparently unrelated test cases.