ir: Make Ord and PartialOrd implementations agree. #1627
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See rust-lang/rust#64710. Bogus implementations were introduced in 230545e, d3e39dc, and 379bb16.
SimonSapin
added a commit
to servo/mozjs
that referenced
this pull request
Sep 24, 2019
… to pick up rust-lang/rust-bindgen#1627
SimonSapin
added a commit
to servo/mozjs
that referenced
this pull request
Sep 24, 2019
… to pick up rust-lang/rust-bindgen#1627
bors-servo
pushed a commit
to servo/mozjs
that referenced
this pull request
Sep 24, 2019
Update rust-bindgen to 0.51 … to pick up rust-lang/rust-bindgen#1627 <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/mozjs/201) <!-- Reviewable:end -->
pcpthm
added a commit
to pcpthm/libffi-sys-rs
that referenced
this pull request
Oct 19, 2019
A bug <rust-lang/rust-bindgen#1627> causes compilation failure in nightly compiler.
pcpthm
added a commit
to pcpthm/libsamplerate-sys
that referenced
this pull request
Oct 19, 2019
A bug rust-lang/rust-bindgen#1627 causes compilation failure in nightly compiler.
This was referenced Oct 28, 2019
This was referenced Nov 12, 2019
danieldulaney
pushed a commit
to danieldulaney/rust-ffmpeg-sys
that referenced
this pull request
Nov 30, 2019
The preivous bindgen version (0.32.0) fails on Rust 1.39 (see rust-lang/rust-bindgen#1627), so an upgrade is needed. However, the new version also breaks when enum values are also defined as macros. Previously, this could be handled with blacklist_type, but the recommended method is by implementing will_parse_macro and returning Ignore for problematic enum variants. This commit implements that method and removes the old method.
meh
pushed a commit
to meh/rust-ffmpeg-sys
that referenced
this pull request
Dec 5, 2019
The preivous bindgen version (0.32.0) fails on Rust 1.39 (see rust-lang/rust-bindgen#1627), so an upgrade is needed. However, the new version also breaks when enum values are also defined as macros. Previously, this could be handled with blacklist_type, but the recommended method is by implementing will_parse_macro and returning Ignore for problematic enum variants. This commit implements that method and removes the old method.
bacek
pushed a commit
to bacek/rust-ffmpeg4-sys
that referenced
this pull request
Feb 29, 2020
The preivous bindgen version (0.32.0) fails on Rust 1.39 (see rust-lang/rust-bindgen#1627), so an upgrade is needed. However, the new version also breaks when enum values are also defined as macros. Previously, this could be handled with blacklist_type, but the recommended method is by implementing will_parse_macro and returning Ignore for problematic enum variants. This commit implements that method and removes the old method.
tilpner
pushed a commit
to tilpner/rust-ffmpeg
that referenced
this pull request
Apr 26, 2023
The preivous bindgen version (0.32.0) fails on Rust 1.39 (see rust-lang/rust-bindgen#1627), so an upgrade is needed. However, the new version also breaks when enum values are also defined as macros. Previously, this could be handled with blacklist_type, but the recommended method is by implementing will_parse_macro and returning Ignore for problematic enum variants. This commit implements that method and removes the old method.
tilpner
pushed a commit
to tilpner/rust-ffmpeg
that referenced
this pull request
Apr 26, 2023
The preivous bindgen version (0.32.0) fails on Rust 1.39 (see rust-lang/rust-bindgen#1627), so an upgrade is needed. However, the new version also breaks when enum values are also defined as macros. Previously, this could be handled with blacklist_type, but the recommended method is by implementing will_parse_macro and returning Ignore for problematic enum variants. This commit implements that method and removes the old method.
tilpner
pushed a commit
to tilpner/rust-ffmpeg
that referenced
this pull request
May 24, 2023
The preivous bindgen version (0.32.0) fails on Rust 1.39 (see rust-lang/rust-bindgen#1627), so an upgrade is needed. However, the new version also breaks when enum values are also defined as macros. Previously, this could be handled with blacklist_type, but the recommended method is by implementing will_parse_macro and returning Ignore for problematic enum variants. This commit implements that method and removes the old method.
tilpner
pushed a commit
to meh/rust-ffmpeg
that referenced
this pull request
May 24, 2023
The preivous bindgen version (0.32.0) fails on Rust 1.39 (see rust-lang/rust-bindgen#1627), so an upgrade is needed. However, the new version also breaks when enum values are also defined as macros. Previously, this could be handled with blacklist_type, but the recommended method is by implementing will_parse_macro and returning Ignore for problematic enum variants. This commit implements that method and removes the old method.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See rust-lang/rust#64710.
Bogus implementations were introduced in 230545e, d3e39dc, and 379bb16.