Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move two attribute lints to be early pass (post expansion) #13650

Closed

Conversation

jdonszelmann
Copy link
Contributor

@jdonszelmann jdonszelmann commented Nov 4, 2024

Please write a short comment explaining your change (or "none" for internal only changes)

changelog:

changelog: [`allow_attributes`]: move from late pass to post expansion early pass
changelog: [`allow_attributes_without_reason`]: move from late pass to post expansion early pass

As a side effect it removes a duplicated warning on line 53 of the allow_attributes test. I discussed this with @xFrednet , and it's mainly to support the attribute rework rust-lang/rust#131229

@rustbot
Copy link
Collaborator

rustbot commented Nov 4, 2024

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Alexendoo (or someone else) some time within the next two weeks.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Nov 4, 2024
@jdonszelmann jdonszelmann deleted the move-lints-to-early branch November 4, 2024 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants