Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename sysroot directories to be more clear #101961

Open
jyn514 opened this issue Sep 18, 2022 · 9 comments
Open

Rename sysroot directories to be more clear #101961

jyn514 opened this issue Sep 18, 2022 · 9 comments
Labels
A-contributor-roadblock Area: Makes things more difficult for new contributors to rust itself E-medium Call for participation: Medium difficulty. Experience needed to fix: Intermediate. E-mentor Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion. S-blocked Status: Blocked on something else such as an RFC or other implementation work. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Comments

@jyn514
Copy link
Member

jyn514 commented Sep 18, 2022 •
edited by rustbot
Loading

These are effectively user facing because they're used for rustup link. So far this has worked reasonably well, but after #101691 stage0-sysroot will become user facing as well, at which point it will become extremely confusing that there's both that and stage0.

I suggest renaming stage0 to bootstrap-sysroot, keeping stage0-sysroot as is and renaming stage1 to stage1-sysroot.

cc @bjorn3 @Mark-Simulacrum

Originally posted by @jyn514 in #101691 (comment)
@jyn514 jyn514 added T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) A-contributor-roadblock Area: Makes things more difficult for new contributors to rust itself E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. labels Sep 18, 2022
@jyn514
Copy link
Member Author

jyn514 commented Sep 19, 2022 •
edited
Loading

Mentoring instructions: change the names in https://github.com/rust-lang/rust/blob/405f0c21608cb41aabc512eed73b2ff707391cab/src/bootstrap/compile.rs#L1107-L1111 and

rust/src/bootstrap/bootstrap.py

Line 600 in b05f97d

subdir = "stage0"

@jyn514 jyn514 added the E-mentor Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion. label Sep 19, 2022
@jyn514 jyn514 mentioned this issue Sep 19, 2022
Closed
@chansuke
Copy link
Contributor

@rustbot claim

@NSHU17
Copy link

NSHU17 commented Sep 30, 2022

@rustbot claim

@rustbot rustbot assigned NSHU17 and unassigned chansuke Sep 30, 2022
@rustbot rustbot assigned rossilor95 and unassigned NSHU17 Oct 9, 2022
@compiler-errors compiler-errors mentioned this issue Oct 20, 2022
Closed
@rossilor95 rossilor95 removed their assignment Nov 8, 2022
@andrewpollack
Copy link
Member

What's the status of availability on this? From #103286 , this looks both assigned and a PR underway

@jyn514
Copy link
Member Author

jyn514 commented Dec 29, 2022 •
edited
Loading

this is mainly waiting on a blog post: #103286 (comment)

I think if you want to work on that independently that would be ok :) it's been a little while since I've heard from @chetankokil

@KittyBorgX
Copy link
Member

Can I take this up if this is still up? (I'm new to contributing to the rust repo)

@jyn514
Copy link
Member Author

jyn514 commented Feb 7, 2023

Hmm, I'm no longer sure I want to do this right now. The changes I proposed in https://jyn.dev/2023/01/12/Bootstrapping-Rust-in-2023.html would change the directories names to something else than what I put in the issue here, but the new names (bootstrap-sysroot, dev-sysroot, dist-sysroot) don't make sense until the new --sysroot flag is added.

@jyn514 jyn514 added E-medium Call for participation: Medium difficulty. Experience needed to fix: Intermediate. S-blocked Status: Blocked on something else such as an RFC or other implementation work. and removed E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. labels Feb 7, 2023
@KittyBorgX
Copy link
Member

I guess this issue is no longer take-able since the S-blocked label has been added then? (I'm really sorry, I'm new to this :D)

@jyn514
Copy link
Member Author

jyn514 commented Feb 7, 2023

@KittyBorgX yes, sorry - I don't think this is a good issue to work on just now, and adding --sysroot is kind of a contentious change that isn't a good first issue.

If you're looking for something to get started with, #101691 might be a good issue :) if that's not a good fit, let's continue the discussion on https://rust-lang.zulipchat.com/#narrow/stream/326414-t-infra.2Fbootstrap so it doesn't create noise here.

This was referenced Feb 17, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-contributor-roadblock Area: Makes things more difficult for new contributors to rust itself E-medium Call for participation: Medium difficulty. Experience needed to fix: Intermediate. E-mentor Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion. S-blocked Status: Blocked on something else such as an RFC or other implementation work. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Rename sysroot directories to be more clear chetankokil/rust
6 participants
@chansuke @jyn514 @andrewpollack @NSHU17 @rossilor95 @KittyBorgX