Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nightly regression (2022-11-22) on rstest #104759

Closed
baloo opened this issue Nov 23, 2022 · 3 comments
Closed

nightly regression (2022-11-22) on rstest #104759

baloo opened this issue Nov 23, 2022 · 3 comments
Assignees
Labels
C-bug Category: This is a bug.

Comments

@baloo
Copy link

baloo commented Nov 23, 2022

Sorry for the badly formatted bug report here, I'm not entirely sure how to report regression on a dependency as I don't have a minimal reproduction code.

$ cargo +nightly-2022-11-22 build 
   Compiling rstest v0.12.0
error: `fixtures::get<'_, impl Iterator<Item = &parse::Fixture>>::{opaque#1}<'_>` does not live long enough
  --> /home/.../.cargo/registry/src/github.com-1ecc6299db9ec823/rstest-0.12.0/src/render/mod.rs:64:13
   |
64 |             TestCaseRender::new(name, attrs, (resolver, &resolver_fixtures))
   |             ^^^^^^^^^^^^^^^^^^^

error: `fixtures::get<'_, impl Iterator<Item = &parse::Fixture>>::{opaque#1}<'_>` does not live long enough
  --> /home/.../.cargo/registry/src/github.com-1ecc6299db9ec823/rstest-0.12.0/src/render/mod.rs:64:13
   |
64 |             TestCaseRender::new(name, attrs, (resolver, &resolver_fixtures))
   |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

it works in nightly-2022-11-21:

$ cargo +nightly-2022-11-21 build
[...]
Finished dev [optimized + debuginfo] target(s) in 27.09s

(problem applies with rstest master version)

@baloo baloo added the C-bug Category: This is a bug. label Nov 23, 2022
@compiler-errors
Copy link
Member

This could use a https://github.com/rust-lang/cargo-bisect-rustc bisection

@compiler-errors compiler-errors added the E-needs-bisection Call for participation: This issue needs bisection: https://github.com/rust-lang/cargo-bisect-rustc label Nov 23, 2022
@baloo
Copy link
Author

baloo commented Nov 23, 2022

searched nightlies: from nightly-2022-11-21 to nightly-2022-11-22
regressed nightly: nightly-2022-11-22
searched commit range: a28f3c8...b7bc90f
regressed commit: 7fe6f36 (#103491 cc @cjgillot)

bisected with cargo-bisect-rustc v0.6.4

Host triple: x86_64-unknown-linux-gnu
Reproduce with:

cargo bisect-rustc --start=2022-11-21 --end=2022-11-22 --preserve

(thanks for the suggestion! never used that tool before!)

@baloo baloo changed the title rstest 0.12.0 nightly regression (2022-11-21) rstest 0.12.0 nightly regression (2022-11-22) Nov 23, 2022
@compiler-errors compiler-errors removed the E-needs-bisection Call for participation: This issue needs bisection: https://github.com/rust-lang/cargo-bisect-rustc label Nov 23, 2022
@baloo baloo changed the title rstest 0.12.0 nightly regression (2022-11-22) nightly regression (2022-11-22) on rstest Nov 23, 2022
@cjgillot cjgillot self-assigned this Nov 23, 2022
@baloo
Copy link
Author

baloo commented Nov 25, 2022

Closing this in favor of #104815 which carries a reproduction example

@baloo baloo closed this as completed Nov 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-bug Category: This is a bug.
Projects
None yet
Development

No branches or pull requests

3 participants