Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't show Cargo.lock warning if Cargo.toml has been modified #107914

Open
jyn514 opened this issue Feb 11, 2023 · 1 comment
Open

Don't show Cargo.lock warning if Cargo.toml has been modified #107914

jyn514 opened this issue Feb 11, 2023 · 1 comment
Labels
C-enhancement Category: An issue proposing an enhancement or a PR with one. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.

Comments

@jyn514
Copy link
Member

jyn514 commented Feb 11, 2023

Rustbot currently posts a warning on any PR that modifies Cargo.lock. this is helpful in cases where Cargo.lock was modified accidentally, for example if cargo ran with an old version of a submodule checked out. However, many PRs change Cargo.lock intentionally and shouldn't get the warning. As a heuristic, we can use "did any Cargo.toml change": if so, it's very likely the change was intentional.

@compiler-errors says this may be tricky since triage bot currently doesn't support conditional pings on files.

cc @BoxyUwU, I think you added this warning originally.

Originally posted by @rustbot in #103993 (comment)

@jyn514 jyn514 added C-enhancement Category: An issue proposing an enhancement or a PR with one. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels Feb 11, 2023
@ChrisDenton
Copy link
Member

Also perhaps if Cargo.lock is the only file modified? This happens when cargo updating dependencies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-enhancement Category: An issue proposing an enhancement or a PR with one. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.
Projects
None yet
Development

No branches or pull requests

2 participants