Tracking Issue for x suggest

[Ezrashaw]

Tracking issue for x suggest subcommand and implementation of recommendations. Note that this isn't a traditional tracking issue for a feature but just a place to keep track of implementation.

See the zulip stream and the initial issue for more information and rationale about this change.

• Initial PR (Create "suggested tests" tool in rustbuild #106249)
• rustc-dev-guide (docs: document new suggest-tests tool rustc-dev-guide#1660)
• tidy lint for suggestion tests, do we want this?
• Further suggestions

cc @albertlarsan68 @jyn514

[Ezrashaw]

@rustbot label +E-easy +E-mentor +E-help-wanted +T-bootstrap

[albertlarsan68]

I think @rust-lang/libs @rust-lang/compiler should participate.
@rustbot label +T-libs +T-compiler

[DavidCoy77]

Hi! I'd love to get started contributing to Rust, but I'd need a little help getting started since this would be my first ever GitHub contribution. You've included the tags Easy, Help-Wanted, and Mentor, so if you're willing to help, I'm eager to get to work. Thanks!

[onur-ozkan]

I don't have the time for mentoring these days(moving my apartment).

[DavidCoy77]

No problem @onur-ozkan

[Dylan-DPC]

@DavidCoy77 if you are still interested in this, you can claim the issue by commenting with @rustbot claim and then ask for help on zulip

[albertlarsan68]

@DavidCoy77, if you still are looking for mentorship on this issue, DM me on Zulip, and we can talk about it.

[hrkskov]

Hi. I'm also interested in this issue as the first time for contribution to rust!

@DavidCoy77
Can I work on this?

[ismailarilik]

Do we want this? =)
And if we want, what should it check?

[Ezrashaw]

Do we want this? =) And if we want, what should it check?

Thanks for the interest! When I wrote the "static suggestions" code, I was vaguely thinking that there could be issues with this code turning into spaghetti and not being formatted correctly (with macros and all). So I thought that a tidy lint could enforce a common style or such like.

rust/src/tools/suggest-tests/src/static_suggestions.rs

Lines 16 to 40 in 9ff5fc4

	static_suggestions! {
	["*.md"] => [
	sug!("test", 0, ["linkchecker"]),
	],
	["compiler/*"] => [
	sug!("check"),
	sug!("test", 1, ["tests/ui", "tests/run-make"]),
	],
	["compiler/rustc_mir_transform/*"] => [
	sug!("test", 1, ["mir-opt"]),
	],
	[
	"compiler/rustc_mir_transform/src/coverage/*",
	"compiler/rustc_codegen_llvm/src/coverageinfo/*",
	] => [
	sug!("test", 1, ["coverage"]),
	],
	["src/librustdoc/*"] => [
	sug!("test", 1, ["rustdoc"]),
	],
	}

That hasn't happened yet, since there aren't that many suggestions, so there's probably not too much point doing work on this until there are more, and a better defined format for defining suggestions is implemented (like in a separate text file?)

I think that the most useful thing with this tool is to increase its coverage, but I'd definitely be happy if you wanted to write some sort of tidy lint for it.