Manually running CI jobs dist-various-{1,2}
complains about missing metrics.json
#112561
Labels
A-contributor-roadblock
Area: Makes things more difficult for new contributors to rust itself
T-infra
Relevant to the infrastructure team, which will review and decide on the PR/issue.
I ran the CI jobs
dist-various-{1,2}
manually by editingsrc/ci/github-actions/ci.yml
but the jobs failed with the following error:However I didn't touch anything on metrics. If I understand correctly, the cause of this error is:
GITHUB_REF=refs/pull/111626/merge
was defined in the environment, according to this logic.DEPLOY=1
was defined in the environment, according to this logic.I only ran
dist-various-{1,2}
but I guess that if otherdist-*
jobs are run manually, the same error would happen, because these jobs would haveDEPLOY=1
orDEPLOY_ALT=1
but metrics would not be enabled asGITHUB_REF
would berefs/pull/<PULL_REQUEST_ID>/merge
.I think this is somewhat confusing to people who want to use CI to test their PRs, because without this error their PRs could have passed the CI. I'm not sure what would be a good fix for this, maybe we could define an environment variable when build metrics are enabled, and check this variable before we fetch
metrics.json
. Or at least the problem could be mentioned in the document.The text was updated successfully, but these errors were encountered: