Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

many feature flags results in poor overflow behavior #112880

Closed
cdmistman opened this issue Jun 21, 2023 · 5 comments · Fixed by #113285
Closed

many feature flags results in poor overflow behavior #112880

cdmistman opened this issue Jun 21, 2023 · 5 comments · Fixed by #113285
Labels
A-rustdoc-ui Area: Rustdoc UI (generated HTML) F-doc_cfg `#![feature(doc_cfg)]` T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Comments

@cdmistman
Copy link

see https://docs.rs/tower-http/latest/tower_http/index.html#enums

image
  • Arc 0.108.1 (39609)
  • MacOS 13.2.1 (22D68)
@syphar
Copy link
Member

syphar commented Jun 21, 2023

this seems like a rustdoc issue, cc @Nemo157 @GuillaumeGomez ?

@syphar
Copy link
Member

syphar commented Jun 21, 2023

( I couldn't quickly reproduce locally yet, need to figure out the arguments first )

@Nemo157
Copy link
Member

Nemo157 commented Jun 21, 2023

Yep, rustdoc issue, I'll transfer it across.

This should be improved by just reducing the number of features shown here with #104991, since a lot of them are already active for the module, but that won't help with the compression/decompression modules in the top-level list.

image

@Nemo157 Nemo157 transferred this issue from rust-lang/docs.rs Jun 21, 2023
@Nemo157 Nemo157 added T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. A-rustdoc-ui Area: Rustdoc UI (generated HTML) F-doc_cfg `#![feature(doc_cfg)]` labels Jun 21, 2023
@Nemo157
Copy link
Member

Nemo157 commented Jun 21, 2023

Actually, rather than #104991 this made me realise there's another issue around how we deal with inlined re-exports, opened #112881 for that.

@GuillaumeGomez
Copy link
Member

It's also kinda related to #87957.

@GuillaumeGomez GuillaumeGomez mentioned this issue Jul 3, 2023
Merged
@bors bors closed this as completed in ef21fd5 Jul 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-rustdoc-ui Area: Rustdoc UI (generated HTML) F-doc_cfg `#![feature(doc_cfg)]` T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[rustdoc] Fix display of long inline cfg labels GuillaumeGomez/rust
4 participants
@Nemo157 @syphar @GuillaumeGomez @cdmistman