Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracking issue for release notes of #125970: CommandExt::before_exec: deprecate safety in edition 2024 #131352

Closed
3 tasks
rustbot opened this issue Oct 7, 2024 · 3 comments
Labels
A-edition-2024 Area: The 2024 edition O-unix Operating system: Unix-like relnotes Marks issues that should be documented in the release notes of the next release. relnotes-tracking-issue Marks issues tracking what text to put in release notes. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Milestone

Comments

@rustbot
Copy link
Collaborator

rustbot commented Oct 7, 2024

This issue tracks the release notes text for #125970.

Steps

  • Proposed text is drafted by PR author (or team) making the noteworthy change.
  • Issue is nominated for release team review of clarity for wider audience.
  • Release team includes text in release notes/blog posts.

Release notes text

The responsible team for the underlying change should edit this section to replace the automatically generated link with a succinct description of what changed, drawing upon text proposed by the author (either in discussion or through direct editing).

# Libraries
- [`CommandExt::before_exec`: deprecate safety in edition 2024](https://github.com/rust-lang/rust/pull/125970)

Tip

Use the previous releases categories to help choose which one(s) to use.
The category will be de-duplicated with all the other ones by the release team.

More than one section can be included if needed.

Release blog section

If the change is notable enough for inclusion in the blog post, the responsible team should add content to this section.
Otherwise leave it empty.

cc @RalfJung, @m-ou-se -- origin issue/PR authors and assignees for starting to draft text

@rustbot rustbot added A-edition-2024 Area: The 2024 edition O-unix Operating system: Unix-like relnotes Marks issues that should be documented in the release notes of the next release. relnotes-tracking-issue Marks issues tracking what text to put in release notes. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. labels Oct 7, 2024
@rustbot rustbot added this to the 1.82.0 milestone Oct 7, 2024
@rustbot rustbot added the needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. label Oct 7, 2024
@Urgau Urgau removed T-libs Relevant to the library team, which will review and decide on the PR/issue. needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. labels Oct 7, 2024
@Urgau
Copy link
Member

Urgau commented Oct 7, 2024

I'm not sure if this needs to be included in the relnote of 1.82.

I think we can just close this on the basis that it will be included in the edition guide.

@jieyouxu
Copy link
Member

jieyouxu commented Oct 7, 2024

Yeah it doesn't make sense to be relnotes in 1.82.

@Urgau
Copy link
Member

Urgau commented Oct 7, 2024

Then closing.

@Urgau Urgau closed this as not planned Won't fix, can't repro, duplicate, stale Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-edition-2024 Area: The 2024 edition O-unix Operating system: Unix-like relnotes Marks issues that should be documented in the release notes of the next release. relnotes-tracking-issue Marks issues tracking what text to put in release notes. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Development

No branches or pull requests

3 participants