Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rust nightly fails to build on xous due to build failure in unwinding #131602

Closed
xobs opened this issue Oct 12, 2024 · 2 comments
Closed

Rust nightly fails to build on xous due to build failure in unwinding #131602

xobs opened this issue Oct 12, 2024 · 2 comments
Labels
O-xous OS: A microkernel OS for privacy in computing T-libs Relevant to the library team, which will review and decide on the PR/issue.

Comments

@xobs
Copy link
Contributor

xobs commented Oct 12, 2024

Recent versions of nightly now fail to build on some targets (e.g. xous) with the following error:

   Compiling unwinding v0.2.2
error[E0787]: the `asm!` macro is not allowed in naked functions
   --> /home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/unwinding-0.2.2/src/unwinder/arch/riscv32.rs:197:9
    |
197 | /         asm!(
198 | |             "
199 | |             mv t0, sp
200 | |             add sp, sp, -0x90
...   |
212 | |             options(noreturn)
213 | |         );
    | |_________^ consider using the `naked_asm!` macro instead

For more information about this error, try `rustc --explain E0787`.
error: could not compile `unwinding` (lib) due to 1 previous error
warning: build failed, waiting for other jobs to finish...
Error: Process completed with exit code 101.

This issue is reported as nbdd0121/unwinding#38 and until this is merged and unwinding is updated to the new version, libstd will not be able to be built for riscv targets.

@rustbot rustbot added the needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. label Oct 12, 2024
@xobs xobs changed the title Rust nightly fails to build on riscv due to unwinding failure Rust nightly fails to build on some target triples due to build failure in unwinding Oct 12, 2024
@saethlin saethlin changed the title Rust nightly fails to build on some target triples due to build failure in unwinding Rust nightly fails to build on xous due to build failure in unwinding Oct 12, 2024
@saethlin
Copy link
Member

This build failure is in fact specific to xous, because only xous uses this third-party crate.

@saethlin saethlin added T-libs Relevant to the library team, which will review and decide on the PR/issue. O-xous OS: A microkernel OS for privacy in computing and removed needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. labels Oct 12, 2024
@xobs
Copy link
Contributor Author

xobs commented Oct 13, 2024

Thanks for confirming that. I'll see when they will tag the next version and then submit a patch here to fix the build.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
O-xous OS: A microkernel OS for privacy in computing T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Development

No branches or pull requests

3 participants