Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rustdoc hangs with diesel #133616

Closed
weiznich opened this issue Nov 29, 2024 · 2 comments · Fixed by #133626
Closed

Rustdoc hangs with diesel #133616

weiznich opened this issue Nov 29, 2024 · 2 comments · Fixed by #133626
Assignees
Labels
C-bug Category: This is a bug. I-hang Issue: The compiler never terminates, due to infinite loops, deadlock, livelock, etc. P-critical Critical priority regression-untriaged Untriaged performance or correctness regression. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Comments

@weiznich
Copy link
Contributor

weiznich commented Nov 29, 2024

Code

diesel-rs/diesel@8939fce

cargo +nightly doc --manifest-path diesel/Cargo.toml --no-deps --no-default-features

I expected to see this happen: Documentation is build in ~5s

Instead, this happened: Rustdoc hangs indefinitely (e.g. https://github.com/diesel-rs/diesel/actions/runs/12069072552/job/33655550946 was canceled after ~6h)

Version it worked on

It most recently worked on: Rust 1.84 (current beta)

Version with regression

rustc --version --verbose:

rustc 1.85.0-nightly (dff3e7ccd 2024-11-26)
binary: rustc
commit-hash: dff3e7ccd4a18958c938136c4ccdc853fcc86194
commit-date: 2024-11-26
host: x86_64-unknown-linux-gnu
release: 1.85.0-nightly
LLVM version: 19.1.4

I've run cargo bisect-rustc to track down the PR that causes this and that points to #133242 (386a7c7), so cc @lcnr

@rustbot modify labels: +regression-from-beta-to-nightly -regression-untriaged +T-rustdoc

@weiznich weiznich added C-bug Category: This is a bug. regression-untriaged Untriaged performance or correctness regression. labels Nov 29, 2024
@rustbot rustbot added I-prioritize Issue: Indicates that prioritization has been requested for this issue. needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. labels Nov 29, 2024
@jieyouxu jieyouxu added T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. I-hang Issue: The compiler never terminates, due to infinite loops, deadlock, livelock, etc. regression-untriaged Untriaged performance or correctness regression. and removed needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. regression-untriaged Untriaged performance or correctness regression. labels Nov 29, 2024
@lcnr lcnr self-assigned this Nov 29, 2024
@lcnr lcnr added P-critical Critical priority and removed I-prioritize Issue: Indicates that prioritization has been requested for this issue. labels Nov 29, 2024
@lcnr
Copy link
Contributor

lcnr commented Nov 29, 2024

thanks for the report and the bisection ❤️ looking into it xx

@weiznich
Copy link
Contributor Author

weiznich commented Dec 3, 2024

I can confirm that diesels documentation builds again. Thanks again for the fast fix ❤

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-bug Category: This is a bug. I-hang Issue: The compiler never terminates, due to infinite loops, deadlock, livelock, etc. P-critical Critical priority regression-untriaged Untriaged performance or correctness regression. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants