-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tutorial: explain how to handle task failure #2080
Comments
There's a section on task failure now in the task tutorial, but it only covers linked failure modes and |
nominating for production ready |
accepted for production ready. (Also, bug triage group agreed that this should drive effort to improve/replace the current task failure API.) |
Visiting for triage. The task failure API is, as far as I know, undergoing some changes, so the tasks tutorial should be updated then. |
Is the new Conditions tutorial covering all the info needed? I think the Failure section of the tutorial describes this, but I'm unsure if |
The tutorial is "conditions and error handling", covers multiple strategies. |
conditions tutorial is invisible? Pr #8764 links it in |
High, 1.0 |
The current conditions and error handling tutorial mentions the strategy of using supervisor tasks a couple times, but I do not think it provides a concrete example of how to code it up. |
part of #11755 |
http://static.rust-lang.org/doc/master/guide-tasks.html#handling-task-failure explains the issue as "While it isn't possible for a task to recover from failure, tasks may notify each other of failure". If this is the case, this issue should be closed. |
The section @kud1ing references above does not provide a sufficient example of what is desired here. The sentence "While it isn't possible for a task to recover from failure, tasks may notify each other of failure" is followed by a concrete example using the @brson mentioned Also, this issue says in the comments: "bug triage group agreed that this [issue] should drive effort to improve/replace the current task failure API"; I don't think that this has happened either. So I do not think the desiderata for this ticket have been satisfied (though I do appreciate @kud1ing taking the time to close it since they were the original filer of the ticket). Reopening. |
Nominating for removal from milestone. |
(not 1.0, P-low) |
The tutorial is not going to improve, and when I re-write the Task guide, it will contain information about how things should fail. Should this just be closed? |
@steveklabnik if you want to attach this ticket to some metabug for your guide (while still leaving this ticket open), that is fine with me. I am opposed to simply closing this ticket, since I interpret closing a ticket as implying that the need described in the issue has been satisfied (or is not something we intend to try to satisfy) -- closing by saying "this issue will be satisfied by this other task over here" is not legitimate IMO. |
Sounds good to me, I don't mind either way. I'll consider this ticket as applying to that guide rather than to the tutorial. |
The language FAQ states:
Please add an explanation to the tutorial (section "Failure" or "Tasks"?) how this would be done.
The text was updated successfully, but these errors were encountered: