Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename "maybe" things to "option" in core::option #2081

Closed
catamorphism opened this issue Mar 30, 2012 · 2 comments
Closed

Rename "maybe" things to "option" in core::option #2081

catamorphism opened this issue Mar 30, 2012 · 2 comments
Labels
C-cleanup Category: PRs that clean code up or issues documenting cleanup. E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.
Milestone

Comments

@catamorphism
Copy link
Contributor

This is my fault -- there are functions called from_maybe, maybe, and so on. Since we spell "maybe" as "option" in Rust, these should be renamed.

@ghost ghost assigned catamorphism Mar 30, 2012
@brson
Copy link
Contributor

brson commented Mar 30, 2012

I find the distinction between these two functions impossible to remember. I know they are taken directly from haskell, but it would be awesome if we could come up with more descriptive names, maybe that follow conventions we've established in the str and vec modules.

I had an issue open to do such for a while but blanked on any better names so closed it.

@brson
Copy link
Contributor

brson commented Mar 30, 2012

And may as well. They all just read to me as 'this is a function that might do something' - great.

@catamorphism catamorphism removed their assignment Jun 16, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-cleanup Category: PRs that clean code up or issues documenting cleanup. E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.
Projects
None yet
Development

No branches or pull requests

2 participants