Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable testing wasm32-unknown-emscripten on travis #42646

Closed
malbarbo opened this issue Jun 13, 2017 · 7 comments
Closed

Enable testing wasm32-unknown-emscripten on travis #42646

malbarbo opened this issue Jun 13, 2017 · 7 comments
Labels
C-tracking-issue Category: An issue tracking the progress of sth. like the implementation of an RFC T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.

Comments

@malbarbo
Copy link
Contributor

A disabled image was added in #42631. We should enable it when we get some capacity on travis.

@frewsxcv frewsxcv added the T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. label Jun 14, 2017
@Mark-Simulacrum Mark-Simulacrum added C-question C-tracking-issue Category: An issue tracking the progress of sth. like the implementation of an RFC and removed C-question labels Jul 27, 2017
@lilianmoraru
Copy link

@alexcrichton Can we re-enable wasm32 in Travis now?

@alexcrichton
Copy link
Member

Unfortunately wasm32 is a "big enough" builder that it requires its own builder, which is much more of a significant investment than just having a standard library.

Did this regress though? I'd imagine that for all practical purposes having CI for asmjs is basically equivalent to CI for wasm

@lilianmoraru
Copy link

@alexcrichton In my case, the asserts were failing only on wasm32: #42518

@alexcrichton
Copy link
Member

Was that ever working though? In the sense that would we have caught a regression if we were running CI?

@lilianmoraru
Copy link

@alexcrichton I was just pointing that asmjs and wasm32 are not equivalent - I myself hit an issue that was specific to wasm32 only.
I can't answer if this would of caught a regression, though.

@alexcrichton
Copy link
Member

Oh yeah sure definitely!

I'm sure we'd catch bugs over time, but I'd personally sort of prefer to wait until we can make wasm a "true" tier 1 target by using the LLVM backend instead of going through emscripten, that may just take awhile :(

@alexcrichton
Copy link
Member

This is done now for wasm32-unknown-unknown which I think is exercising LLVM's backend (the goal here), so I'm going to close.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-tracking-issue Category: An issue tracking the progress of sth. like the implementation of an RFC T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.
Projects
None yet
Development

No branches or pull requests

5 participants