Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

im beta regression #44446

Closed
est31 opened this issue Sep 9, 2017 · 3 comments
Closed

im beta regression #44446

est31 opened this issue Sep 9, 2017 · 3 comments
Labels
regression-from-stable-to-beta Performance or correctness regression from stable to beta. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Milestone

Comments

@est31
Copy link
Member

est31 commented Sep 9, 2017

The tests of the im crate version 6.0.0 fail on latest beta 1.21, while they work on stable. The error output (full log):

error[E0282]: type annotations needed
    --> src/map/mod.rs:1400:18
     |
1400 |         let c1 = Map::singleton(v1, p1);
     |             --   ^^^^^^^^^^^^^^ cannot infer type for `K`
     |             |
     |             consider giving `c1` a type

cc @bodil

@retep998 retep998 added the regression-from-stable-to-beta Performance or correctness regression from stable to beta. label Sep 9, 2017
@est31
Copy link
Member Author

est31 commented Sep 9, 2017

Bisected to 560b6ca -- #42565 cc @murarth @aturon

@arielb1 arielb1 added the T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. label Sep 11, 2017
@arielb1
Copy link
Contributor

arielb1 commented Sep 11, 2017

Relevant excerpts:

https://github.com/bodil/im-rs/blob/5a48a656a67805637b84daa1c9b746c2c531181b/src/map/mod.rs#L98-L104

https://github.com/bodil/im-rs/blob/5a48a656a67805637b84daa1c9b746c2c531181b/src/map/mod.rs#L1392-L1403

impl<T> From<T> for Arc<T> {

impl From<String> for Arc<str> {

Looks like we added a new impl and now singleton can't decide whether it should contain Arc<String> or Arc<str>. Expected inference breakage.

@alexcrichton
Copy link
Member

The libs team discussed this the other day and the decision was that this indeed falls under expected inference breakage (thanks for the investigation @arielb1!). @KodrAus has prepared a PR with a fix, so I'll close this in the meantime.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
regression-from-stable-to-beta Performance or correctness regression from stable to beta. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Development

No branches or pull requests

4 participants